10
X

Accordion Madness

read 234 comments

A few weeks ago I wrote about two ways we can achieve the "accordion menu" effect, and I promised to describe a third option. Well, this is it, Option 3. But first, here is a list of my other show-hide-toggle entries, as well as Jörn Zaefferer's accordion menu plug-in:

Option 3: Zero or One

Remember from More Showing, More Hiding that we are working with a simple <h3> / <div> structure:

HTML:
  1. <div class="demo-show2">
  2.   <h3>Title 1</h3>
  3.   <div>Lorem...</div>
  4.   <h3>Title 2</h3>
  5.   <div>Ipsum...</div>
  6.   <h3>Title 3</h3>
  7.   <div>Dolor...</div>
  8. </div>

With this option #3, we start with all of the <div>s hidden. If we click on one of the headings, the following <div> will slide down. If we click on the same heading again, that <div> will slide back up. Clicking on on any heading will also hide all of the other <div>s — the ones that don't immediately follow it. Therefore, no more than one <div> can be open a a time.

Continue Reading Below

To achieve this, we start by hiding all of the <div>s inside the first (:eq(0)) <div class="demo-show2">:

JavaScript:
  1. $(document).ready(function() {
  2.   $('div.demo-show2> div').hide();  
  3. });

Then we set up the .click() method for all of the relevant <h3> elements

JavaScript:
  1. $(document).ready(function() {
  2.   // ...
  3.   $('div.demo-show2> h3').click(function() {
  4.   // ...
  5.   });
  6. });

Finally, inside the .click(), we toggle the >div< immediately following the clicked >h3< and hide all the other >div<s that are visible siblings of the toggled one. Here is the complete script:

JavaScript:
  1. $(document).ready(function() {
  2.   $('div.demo-show2> div').hide();  
  3.   $('div.demo-show2> h3').click(function() {
  4.     $(this).next('div').slideToggle('fast')
  5.     .siblings('div:visible').slideUp('fast');
  6.   });
  7. });

Now, on to the show:

Title 1

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

Title 2

Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

Title 3

Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

Pretty simple, straightforward effect. Let's jazz it up a bit.

Option 3b: Zero or One, Queued Effects

Here we're going to keep the same rules about having either one or no <div>s visible at a time. But now we're going to queue the effects. In other words, we'll make the visible one slide up before the next one slides down.

The first couple lines of code are the same as those in option 3a:

JavaScript:
  1. $(document).ready(function() {
  2.   $('div.demo-show2> div').hide();  
  3.   $('div.demo-show2> h3').click(function() {
  4.     [...]
  5.   });
  6. });

But now things get a touch more complicated. We're going to set a couple variables—one for the next sibling of the clicked <h3> and one for all siblings of that next one, as long as they are visible <div>s:

JavaScript:
  1. $(document).ready(function() {
  2.   $('div.demo-show2> div').hide();  
  3.   $('div.demo-show2> h3').click(function() {
  4.     var $nextDiv = $(this).next();
  5.     var $visibleSiblings = $nextDiv.siblings('div:visible');
  6.   });
  7. });

So, now that we have the two variables, let's put them to use. We want to slide any visible sibling <div> up first and then toggle the next <div> using .slideToggle(). But we want this queued effect to occur only if there actually is a visible div. So, we'll use an if statement.

JavaScript:
  1. $(document).ready(function() {
  2.   $('div.demo-show2> div').hide();  
  3.   $('div.demo-show2> h3').click(function() {
  4.     var $nextDiv = $(this).next();
  5.     var $visibleSiblings = $nextDiv.siblings('div:visible');
  6.  
  7.     if ($visibleSiblings.length ) {
  8.       $visibleSiblings.slideUp('fast', function() {
  9.         $nextDiv.slideToggle('fast');
  10.       });
  11.     }
  12.   });
  13. });

The trick here for getting the one effect to occur after the other is to put the .slideToggle() code in the .slideUp() method's callback function.

Now, we just need to add the else condition for those times when there aren't any visible <div>s:

JavaScript:
  1. $(document).ready(function() {
  2.   $('div.demo-show2> div').hide();  
  3.   $('div.demo-show2> h3').click(function() {
  4.     var $nextDiv = $(this).next();
  5.     var $visibleSiblings = $nextDiv.siblings('div:visible');
  6.  
  7.     if ($visibleSiblings.length ) {
  8.       $visibleSiblings.slideUp('fast', function() {
  9.         $nextDiv.slideToggle('fast');
  10.       });
  11.     } else {
  12.        $nextDiv.slideToggle('fast');
  13.     }
  14.   });
  15. });

As you can see, for those cases we use a simple .slideToggle() on the next <div>.

See this code in action below. Enjoy!

Title 1

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

Title 2

Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

Title 3

Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.


comment feed

234 comments

  1. Ty

    Finally, the correct functionality required.
    I think I prefer the first non-jazzed up version, the second makes me motion sick, lol.
    Way to go, good work.

    Hint: These div's can contain image buttons not just text, and background colors and borders.'
    Dig into your Css bag-o-tricks for that people, have fun!

  2. Yes, thanks for adding that hint, Ty. There are multifarious ways to prettify these menus, for sure.

  3. Luis Martins

    It doesn’t behave quite right on IE7, but excellent work. Thanks.

  4. Hi Luis, by not behaving quite right in IE7, I assume you mean that there is a little bump at the end of the slide. I just fixed that by giving the paragraphs inside those <div> elements a style declaration of margin-top: 0. Thanks for the heads-up. Let me know if you see any other issues.

  5. ziggy

    --I think I prefer the first non-jazzed up version, the second makes me motion sick, lol.

    Yeah, me too. Jazzy effects look nice at first but quickly get annoying when you have to use them a lot.

  6. ziggy

    btw, in ie6 it won't open unless you click the text; after one time opening it you can click anywhere on the blocks to activate them.

    opera works but doesn't show the proper "hand" cursor at all.

    I know it's not a plugin, but thought I'd note it as people ARE going to use your code.

  7. Joram Oudenaarde

    Finally a great explanation on those slick movement-options :)
    Thanks a lot for making this, hehe.

    There's only one little question in addition to your tutorial;
    In your tutorial, the text shows up belów the buttons after you press it. Could you tell us how we could make a version where the text shows up abóve the button? So if you press that button, the button will slide down, showing the text that's been hidden "above" it. :)

    Regards,
    Joram

  8. @ziggy: I fixed both the IE6 and the Opera issue with a little modification to the CSS. IE6 needs the width to be defined for the h3, and Opera needs the cursor to be defined. here is the relevant CSS:

    .demo-show2 {
      width: 350px;
      margin: 1em .5em;
    }
    .demo-show2 h3 {
      margin: 0;
      padding: 5px;
      width: 338px;
      background: #bfcd93;
      border-top: 1px solid #386785;
      border-bottom: 1px solid #386785;
      cursor: pointer;
    }

    @Joram: You can move the div elements above the h3s in your markup, and then use .prev() instead of .next().

  9. joram oudenaarde

    Very much appreciated :)

    One little question if you don't mind;
    I know that in JavaScript, you can set a fixed speed (don't ask me how though).
    Is it possible to make the animation slower? I see you used 'fast'
    as a tag in JavaScript... is that the speed-indicator?

    Thanks in advance (again) :)

  10. Hey Joram, no problem.

    Yeah, I set the animation to "fast" but you can set it to whatever you want, either by using a label ("fast" or "slow" or "normal") or by using a number. Numeric speeds are in milliseconds and don't take quotation marks.

    So, if you wanted the .slideToggle() effect to take a full second, you would do this:
    .slideToggle(1000).

  11. Joram Oudenaarde

    Thanks again Karl :)

    Time to experiment, hehe.

  12. Chris Ovenden

    IMO the first version of this is exactly how these things should be done: accessible, usable, non-intrusive (and no motion sickness...) Excellent work, Karl!

  13. Yansky

    Hi guys, this isn't a comment on the post as such, but a tutorial suggestion. Could you write a tutorial about the use of "$(this)" within a callback and the right way to use it in different circumstances? I seem to always have trouble with understanding how it works and the proper syntax with which to use it.

    For example, I was recently trying to replace text in an array, and even though I managed to figure it out (with great help from the mailing list), I still don't fully understand "$(this)". :-)

    This was my text replace code BTW:

    $('a > span').contains('index.cfm?a=wiki&tag=').each(function(i){
    var $this = $(this);
    $this.html( $this.html().replace( /index.cfm\?\a\=wiki\&tag\=/gi, "")).css({"border-bottom": "1px dotted #773300", color: "#773300", "text-decoration": "none"}).siblings().hide();
    });

  14. Nicki

    Hi, little question: how can i show the first div visible on startup?

  15. Hi Nicki,

    Look at Option 2 in More Showing, More Hiding for an example of making the first div initially visible. If you have any further questions after reading through that one, drop in another comment.

  16. Justin

    Hey, Karl. I love the tutorial. It's really helped me a lot. My issue is that I'm using nested lists to structure my navigation and .siblings obviously won't work for that. Do you have any insight on how I might remedy this issue? I'm new to this so I don't know how to traverse the dom to find the elements I need to hide.

    $(document).ready(function() {
    	$("ul.demo> li> ul").hide(); 
    	$("ul.demo> li> span").click(function() {
    		$(this).next("ul").slideToggle("fast").siblings("ul.subnav:visible").slideUp("fast");
    	});
    });
    
    
    
    <a href="/ccd/category.do?...">Desktop computers (+)				
    		
    			<a href="#">AMD</a>
    			<a href="#">Intel</a>
    			
    		
    	
    	<a href="/ccd/category.do?...">Notebook computers (+)
    		
    			<a href="#">AMD</a>
    			<a href="#">Intel</a>
  17. Justin

    One of the wonderful people in the #jquery irc channel was able to help me with this last night. The answer is...

    $(this).next('ul').slideToggle('fast')
    .parent().siblings('li').find('ul:visible').slideUp('fast');

  18. Hey Justin, glad to hear you got help with that. Sorry I couldn't reply to you any sooner. (working on the book.)

  19. api3376

    hi everyone!
    i'd like to use accordion in horizontal mode..
    does anyone know a way to do that??????
    help me ;)
    thanks

  20. charles

    Hi,

    i got a list, each of its items must contain a div. in fact each of my "li class="titre"" tag corresponds to the "h3" tag of the first example and my own divs contained in each li have their proper "contenu_article" class. i'm a beginner at jquery and i'm trying to make this work

    $('div.demo-show2> div').hide();
    $('div.demo-show2> li class="titre"').click(function()
    {
    $(this).next('div').("contenu_article").slideToggle('fast').siblings('div:visible').slideUp('fast');
    });

    but it doesn't. i think that this part : ('div.demo-show2> li class="titre"') is badly written. does anyone can help me please ?

  21. Hi Charles,

    I'm not sure exactly what you're trying to show/hide. Still, I see a couple problems with the selector expression you're using. It looks like you're using HTML syntax ( e.g. li class="titre" ) instead of CSS syntax ( e.g. li.titre ). Switching your selectors to CSS syntax will go a long way towards getting your code to work. Also, you can remove the code that is specifically related to my example ( e.g. div.demo-show2 ).

    If I'm understanding you correctly, you might want to try something like this:

    $('li.titre').click(function() {
      $(this).next('div.contenu_article').slideToggle('fast')
        .siblings('div:visible').slideUp('fast');
    });
  22. Brent

    Thanks a lot for your article, this helped me in a jam!

  23. Aaron

    I have a weird question. First let me say this code is great and almost what i am looking for.

    I want to have images that when you mouse over it fades in a div on the right side of it and when mouse over the next one it fades out the previous and fades in the next div.

    I have tried modifying this code but am having no luck.

    Here is example HTML of the layout.


    <table width="100%" border="0" cellspacing="0" cellpadding="0" id="ImageTable">
    <tr>
    <td class="images">
    <A href="#"><IMG src="Image.jpg" border="0"></A>
    <A href="#"><IMG src="Image.jpg" border="0"></A>
    <A href="#"><IMG src="Image.jpg" border="0"></A>
    </td>
    <td class="divs">
    <div>1 This is the box that will be shown and hidden and toggled at your whim.</div>
    <div>2 This is the box that will be shown and hidden and toggled at your whim.</div>
    <div>3 This is the box that will be shown and hidden and toggled at your whim.</div>
    </td>
    </tr>
    </table>

    I am so lost on how to get this to do this and can not tell you how much i would appreciate it if someone could help me out.

    Thanks again for everything and great work!!!

    Aaron

  24. GoodMixer

    I'm having problems getting this to work in ie7. Viewing this example in ie7 works fine. My html is

    <div class="demo-show2">
    <h3>Tell a Friend</h3>
    <div class="form_bg">Lorem ipsum dolor.</div>
    <h3>Subscribe to Newsletter</h3>
    <div class="form_bg">In tincidunt nisi tempus feliss.</div>
    <h3>Title 3</h3>
    <div class="form_bg">In tincidunt nisi tempus felis. Donec aliquam,</div>
    </div>

    and I'm calling 2 .js files in the <head> jquery.js and show_hide.js.

    show_hide.js is the following code

    $(document).ready(function() {
    $('div.demo-show2> div').hide();
    $('div.demo-show2> h3').click(function() {
    var $nextDiv = $(this).next();
    var $visibleSiblings = $nextDiv.siblings('div:visible');
    if ($visibleSiblings.length ) {
    $visibleSiblings.slideUp('fast', function() {
    $nextDiv.slideToggle('fast');
    });
    } else {
    $nextDiv.slideToggle('fast');
    }
    });
    });

    Any help would be great I'm really stumped on this one. Works fine in firefox.....

  25. Hi GoodMixer, I pasted your code into another doc and tested it in IE7. Seems to be working fine for me: accordion test. Let me know if it works for you, too.

  26. GoodMixer

    Thanks for looking at that Karl. It seems to work for me when I have the script in the head tag but not when I have it in an external .js file. Is there something I am missing? I don't know. I guess I'll just forget about the external file. Thanks again.

  27. Not a problem. I'm not sure why it's not working for you when the code is in an external .js file, though. That shouldn't really have anything to do with it. I've moved my test file's script to an external file, and it's still working. Take another look.

    A couple things to consider: Make sure you are including the jquery.js file before the other one. Also, it wouldn't hurt to double-check the path to the .js file, just in case there was a typo or something. Let me know what you discover!

  28. GoodMixer

    I'm really not getting anywhere with this. I'm running this script on an Expression Engine site and it work great in firefox but ie (6 and 7) it works sometimes and then if you refresh it will just show all 3 boxes with content and nothing clickable. I can't see why it would work sometimes??? Unless EE isn't loading the full script.

    I am running the jquery.js first. You are welcome to have a look if you want to as I'm not getting anywhere with it. http://www.mickykelleher.com/golf/ (The site is a work in progress)

  29. John Williams

    In the first menu "Option 3: Zero or One", how do I make to open the text in a certain title when the page loads? (the text inside Title1 or Title2 or Title3).

    i managed to load it with Title1 opened:

    $(document).ready(function() {
    $('div.demo-show2:eq(0) > div:gt(0)').hide();
    $('div.demo-show2> h3').click(function() {
    $(this).next('div').slideToggle('normal')
    .siblings('div:visible').slideUp('normal');
    });
    });

    or Title1 + Title2 at the same time

    $(document).ready(function() {
    $('div.demo-show2:eq(0) > div:gt(1)').hide();
    $('div.demo-show2> h3').click(function() {
    $(this).next('div').slideToggle('normal')
    .siblings('div:visible').slideUp('normal');
    });
    });

    or Title1+ Title2+Title3 at the same time

    $(document).ready(function() {
    $('div.demo-show2:eq(0) > div:gt(2)').hide();
    $('div.demo-show2> h3').click(function() {
    $(this).next('div').slideToggle('normal')
    .siblings('div:visible').slideUp('normal');
    });
    });

    Thank you.

  30. Vivek

    Hi, as i am viewing the above demos of after a tutorials, they are shuttering in the Firefox 2.0.3
    But when i view the same in IE6.0 it slides beautifully. In FF 2.0.3 it slides after a bit of shutter.

  31. John Williams

    Try removing or diminusing, in the CSS code, the top and bottom padding of demo-show2.div. Include that height in an old html variant (a table with a row of the same hight for example). I hope I understood your question write.

  32. Hi Karl.

    First just wanna say thanks for this plugin, it's great.

    Just needed to know if there is any easy way to convert this plugin to an horizontal accordion.

    Thanks in advance.

    Best regards Sérgio pinto

  33. Dena

    Thanks for the clear example!

    Is there an easy way to change the h3 content on toggle? For instance, from "Open" to "Close"?

    Thanks!

  34. layZboy

    I have a question. If i want the section I click on to become the top, how do I do this? I was curious since after i used it and my sections were about 4 paragraphs longer it became annoying to scroll to the correct section each time. I was wondering if there's a way to expand/collapse, as well as scroll to the proper section all at once. Thanks.

  35. mpmchugh

    Hi,

    How would one best go about having the selected header change colors when selected? And then revert when another is selected?

    Thanks.

    -mpm

  36. huphtur

    mpmchugh: maybe look into addClass?

    Karl: Any tips on how to get anchors to work ala how moo.fx does it?

  37. Hi huphtur,

    Maybe use this script in conjunction with Interface's .ScrollTo() method in the FX module? Take a look at the FX documentation and see if it'll do what you're shooting for. If not, let me know.

  38. huphtur

    Karl: not sure how Interface's .Scrollto() would help with this. Basically I need to know how I can use the jquery/accordion madness to open an anchor with an id attribute. For instance: Title2, or Title1 (your demo with some added markup). I've been searching jquery docs for anchor and target info, but have been unable to find anything. Maybe I'm looking at the wrong stuff?

  39. Oh, sorry huphtur. Totally misread your question. I just took another look at the moo.fx page that you linked to, and, I have to say, I don't get why they're using those anchors in the way that they are. For example, they have <a href="whatsnew">what's new</a>, but they don't have anything on the page with id="whatsnew" or even an old-school anchor like <a name="whatsnew"></a>. It adds the hash to the URL, but since the anchors don't exist on the page, clicking on those headings keeps adding unnecessarily to the history, making for terrible "back button" navigation.

    Anyway, Klaus Hartl's Tabs plugin does a really nice job of using anchors the right way, tracking history so that the back button will actually do something. If you check that one out, I'm sure you'll be able to glean some really useful stuff from it. It's not the straightforward accordion, but it works on the same principle.

    I realize this is the second time I've urged you to take a look at another plugin to find the solution, but I'm really not trying to avoid helping you. Really!

  40. huphtur

    That's indeed what I was looking for. Thanks for the tips!

  41. Justin

    Karl,

    On the apple site they have their own version of what appears to be an accordion type menu. It's on the right and left side when you mouseover. I'm sure you've seen it already.

    My question: Have you been able to mimic this effect with jQuery. On every jQuery accordion i've seen and made, the bottom will always make some sort of bumping motion. Depending on the speed it might be a big bump or a small bump. I've been able to minimize it, but never get rid of it like Apple has. Any ideas? I probably need an entirely different approach.

    link for reference: http://www.apple.com/mac/

  42. Hi Justin,
    I'm not seeing the "bumping motion" in the examples above for this blog entry. I might not be understanding what you mean by "bumping," though. One thing you might want to try is setting a height for the containing element like Apple does. That way, everything below it will stay in the same spot even during the sliding animations. Hope that helps point you in the right direction. If this doesn't make sense or doesn't work for you, let me know and I'll try to put up a demo over the weekend.

  43. Justin

    K. Bumping may have been a bad description. It's also more noticeable when you have more than 3 tabs. I will try to describe it better:

    In the last example on this page before these comments, if Title 1 is open and i click Title 2, then title 3 moves up with it. If you set the show and hide to the same speed, then title 3 will just make a small move down and up, a "bump" if you will. You can see it in my example here:

    http://www.robustness.org/dev/jquery/slider/slider-jquery.html
    (it's a small bump on the 4th tab, when you click any of the tabs, just moves down and up really quick)

    On the apple page, if i have the first tab open and mouseover the second tab, the third tab does not move at all. That's the effect i'm looking for. It loosk more solid. I have used javascript to set heights on the container and the tabs themselves, and this stops the tabs from interfering with the rest of the page, however the tabs themselves make these jumps.

    I hope this clarifies it a bit.

  44. Ah! I definitely see what you mean now. I don't know what could be causing this, but if you post the question to the jQuery Google Group, maybe someone who is more familiar with the fx.js component of the jQuery source code could provide a solution. Otherwise, this could be a bug that should be logged n Trac on the jquery.com. But posting the question to the Google Group is definitely the first step. Make sure you provide the URL, too. That was really helpful for seeing what the problem is.

  45. Bobby Digital

    I know someone else asked this but I can't find the solution anywhere.

    How can I have the class of an h3 change when you click on it, and then revert to normal when you either

    1. click on it again, or
    2. click on a different h3?

    I tried the following:

    $('this').toggleClass('active');

    inside the conditional statement of your "//queued showing and hiding" example, but I quickly discovered that I have no clue what I am doing.The class changes but stays that way when I click on other h3's

    Any ideas?

  46. Bobby Digital

    Woops, I posted the wrong code. This is as far as I can get here:

    $(document).ready(function() {
    $('div.demo-show2:eq(0) > div').hide();
    $('div.demo-show2:eq(0) > h3').click(function() {
    $(this).next('div').slideToggle('fast')
    .siblings('div:visible').slideUp('fast');
    $(this).toggleClass('active')
    .siblings('h3').toggleClass('normal');
    });
    });

  47. Bobby Digital

    Wow, I actually figured it out! Jquery is easy!!

    $(document).ready(function() {
    $('div.demo-show2:eq(0) > div').hide();
    $('div.demo-show2:eq(0) > h3').click(function() {
    $(this).next('div').slideToggle('fast')
    .siblings('div:visible').slideUp('fast');
    $(this).addClass('arrow-down')
    .siblings('h3').removeClass('arrow-down');
    });
    });

  48. Hey Bobby, Congratulations! I'm glad I didn't see your posts until now. It's so much more satisfying to figure these things out on your own, isn't it? Don't hesitate to ask for help, though, if you run into any further snags.

  49. I'm trying to accomplish something similar, but haven't figured out how to add Bobby's idead to my set up.

    I'm curently using this html:


    Services

    For the web

    Web Design
    Squared Eye is known for our attention to detail, our love of all things easy to use, and the way we can take your needs and find a web solution for them.

    Web Development
    If you need your website to live and breath — to do more than just be an online brochure — Squared Eye can take your site to the next level, integrating anything from e-commerce to video and a myriad of helpful technologies in-between.

    and this JS:


    $(document).ready(function() {
    $('ul.accordion> li> p').hide();
    $('ul.accordion> li> h4').click(function() {
    var $nextDiv = $(this).next();
    var $visibleSiblings = $nextDiv.siblings('p:visible');
    if ($visibleSiblings.length ) {
    $visibleSiblings.slideUp('fast', function() {
    $nextDiv.slideToggle('fast');
    });
    } else {
    $nextDiv.slideToggle('fast');
    }
    });
    });

    I've tried adding bobby's code in there in various places, but can't figure out the right solution.
    the page I'm working on is here

  50. Hi Matthew,
    Would you mind posting that link to your page again? For some reason it has no href.

  51. Karl,
    Man, what a numskull. Sorry, too many things at once :) Here is the link. Thanks :)

  52. Hi Matthew, no worries.

    It looks like you're sliding down the <p>s just fine; but getting others to slide back up seems to be the problem. Is that right?

    The cause of the problem is that you're selecting for visible siblings, but since those other <p>s are contained within separate <li>s, they aren't siblings.

    Try replacing this line:
    var $visibleSiblings = $nextDiv.siblings('p:visible');
    with this:
    var $visibleSiblings = $(this).parent().siblings().find('p:visible');

    Let me know how that goes.

  53. Karl,
    Thanks, that did the trick. To understand it correctly the $(this).parent().siblings() is because of the nested unordered list?

    On another note, in accordance with the comments above about adding or removing a class based upon whether the paragraph is open or closed.

    I had thought I might have it by adding $(this).parent().addClass('arrow-down') thinking that was targetting the nested list element, but it appears I was wrong.

  54. Hi Matt,
    My pleasure. Doesn't matter if the unordered list is nested, just that the h4 within each li has only one sibling -- a p. So, you need to go up from the clicked h4 to its li, then select all of that li's sibling lis, and within those find all ps and slide them up.

    About the addClass(), what you have should work. I peeked at your code and didn't see you doing that. If you wanna shoot the whole script to me so I can take a look at it, feel free to send it through the contact form.

  55. bs

    i want to add dynamic div. how can i give dynamic div name inside $('div.demo-show2> div').

  56. Caleb

    Hi Karl,

    I'm trying to build upon the examples you have set. How can i create a 'close' option within each div?

    Here's whats i'm working on so far.

    thanks! your help would be greatly appreciated.

    caleb

  57. Justin

    Caleb,

    Place a class "close" on the div containing the close text. Then place this in your javascript after your other click function.

    $('.close').click(function() {

    $(this).parent().slideUp('slow');

    });

  58. Caleb

    thanks justin! :)

  59. Is there anyway to prevent the menu height from jumping around. In other words can the height be fixed and the menus open and close to fill it?

    Thanks

    Mitch

  60. Hi Mitch,
    Sure. I think all you need to do is set the height of the menu's containing element in your stylesheet. If that doesn't make sense, let me know and I'll explain further.

  61. does anyone know how this side scrolling effect is achieved?
    http://www.hotel-oxford.ro/

    It uses moo.tools.js and a clever http:// call in a file called core.js and another named core.ajax.js . The scrolling effect seems to be buried in the last third of the page:
    ... "&contact=1&ajax=1" load_content('contact_div', SITE_ROOT, poststr)...

    I can get everything to work except for the sliding action of each "page" even though all the code is on the index page itself. Just looking for a tip on how the core.js interacts with the info on the index page.

    I just thought this would be a good question for the Jscript / JAVAscript gurus.

  62. Big Brad

    I'm having no issues with the working of the accordion ... it's brilliant infact.

    What I was wondering was the following:

    i managed to set image backgrounds for the h3's in the css for a:link as well as a:hover - and they work fine.

    what i cannot wrap my head around is how I would be able to create a "active" state with yet another img background.

    any takers?

  63. Hi Brad,
    I'd use a single background image and shift either its x or y position. For example, if your h3s are 24px tall, you could do something like this:

    h3 a {
      background: url(my-image.jpg) no-repeat 0 0;
     display: block;
    }
    h3 a:hover {
      background-position: 0 -24px;
    }
    h3 a:active {
      background-position:0 -48px;
    }

    You'll probably need to use return false; in your script so it doesn't fire the default click event.

  64. caleb

    is it possible to click and open all ? if so, how can i do that?

    thanks :)

  65. Hi Caleb, inside the .click(), just do $(this).siblings('div').slideDown();

  66. caleb

    hi karl,

    sorry but i'm not very good at javascript.

    what's the div variable?

    heres an example of what i got.

    http://oonagi.org/test/

    my js file is here.

    thanks so much. :)

  67. Hi Caleb, I'm guessing now that you want a separate element that, when clicked, will open all of the hidden items, but I'm not sure because I can't see anything on that page that you might want to bind to that behavior.

    The first thing I'd do is change all those span elements to divs, because they contain paragraphs. spans should only contain inline elements.

    Then, try something like this (inside your document.ready):

    $('someElement').click(function() {
      $('div.show-hide > div').slideToggle();
    });

    You'll need to change 'someElement' to something that relates to an element on your page. This will slide (up or down) all divs that are direct children of <div class="show-hide">

    btw, in my previous example, div isn't a variable; it's an element.

    Hope that helps

  68. Hey all
    Great tutorial...new to jquery but am loving it switch from mootools and not looking back. i am having one problem though. i have multiple instances of a div with the content i want to hide at first and multiple instances of a click handle. the problem is with only showing one div at a time... the way it works now is that the user can click multiple show/hide links and the previous one will still show itself until you toggle it. here is the html:

    
    <div class="moduleDescription">
      <ul>
        <li>
          <!-- start description -->
          <a href="http://www.tmz.com/2007/09/04/glaad-accepts-jerrys-mea-culpa/"> 
            GLAAD Accepts Jerry's Mea Culpa </a><br />
          - <span class="date">4 Sep 2007 | </span>
          <!-- end description -->
        </li>
      </ul>
      <h6>Show/Hide</h6>
      <div>
        <p>
        <p>Filed under: <a href="http://www.tmz.com/category/tv/" rel="tag">TV</a></p>
        <a href="http://www.tmz.com">TMZ.com</a>:  After Jerry Lewis apologized
          ... <a href="http://www.tmz.com/2007/09/04/glaad-accepts-jerrys-mea-culpa/">Read more</a><br/>
        <br/>
        </p>
      </div>
    </div>
    <!-- end item -->
    <div class="moduleDescription">
    <ul>
      <li>
        <!-- start description -->
        <a href="http://www.tmz.com/2007/09/04/lewis-takes-foot-out-of-mouth-issues-statement/"> 
         Lewis Takes Foot Out of Mouth, Issues Statement </a><br />
        - <span class="date">4 Sep 2007 | </span>
        <!-- end description -->
      </li>
    </ul>
    <h6>Show/Hide</h6>
    <div>
      <p>
      <p>Filed under: <a href="http://www.tmz.com/category/tv/" rel="tag">TV</a>, 
       <a href="http://www.tmz.com/category/wacky-and-weird/">Wacky and Weird</a></p>
      <a href="http://www.tmz.com">TMZ.com</a>:  Alleged comedian Jerry Lewis has issued...
       ... <a href="http://www.tmz.com/2007/09/04/...">Read more</a><br/>
      <br/>
      </p>
    </div>
    

    and here is the js

    
    <script type="text/javascript">
    $(document).ready(function() {
      $('div.moduleDescription> div').hide();
      $('div.moduleDescription> h6').click(function() {
    	var $nextDiv = $(this).next();
    	var $visibleSiblings = $nextDiv.siblings('div:visible');
    	if ($visibleSiblings.length ) {
    	  $visibleSiblings.slideUp('fast', function() {
    		$nextDiv.slideToggle('fast');
    	  });
    	} else {
    	   $nextDiv.slideToggle('fast');
    	}
      });
    });
    </script>
    

    the test url is here:
    http://celebrityfed.com/v-1-3c.php

    any help would be awesome...thank you!

  69. It looks like your problem is with the $visibleSiblings variable. You have each h6/div pair wrapped in its own <div.moduleDescription>.

    You should be able to get this working by just changing the one line. Insead of this . . .

    var $visibleSiblings = $nextDiv.siblings('div:visible');

    try this . . .

    var $visibleSiblings = $(this).parent().siblings().children('div:visible');

  70. eric maguire

    karl

    thank you very much it seemed to work.....but it kinda caused an adverse effect. for some reason it is controlling the "rate this feed" div now too. trying to figure it out....thanks a lot for the help. here is what ive got so far http://celebrityfed.com/v-1-3c.php

    thanks again for your help!!!!!

  71. caleb

    Hi Karl,

    Thank for your help..

    I've tried the suggestion you provided and it works, but theres this bug issue when say i click expand all, and then i click collapse 1 item, everything collapses and it starts going up and down.

    I've also doing this.

    $('.ExpandAll').click(function() {
    $('div.show-hide > div').slideDown();
    });

    $('.CollapseAll').click(function() {
    $('div.show-hide > div').slideUp();
    });

    But it still has the same bug. Isit possible to be fixed?

    test here

  72. Eric, I guess I had missed that in the markup. Oops. You'll need to specify the class in your siblings method then:

    var $visibleSiblings = $(this).parent().siblings('div.moduleDescription').children('div:visible');

    That should do it.

  73. Caleb, I've been shooting blind with my suggestions for you so far. It really helps me to be able to see a live demo page of some sort. Could you post a link so that I can help you work it out?

  74. eric maguire

    karl

    worked like a charm...thanks so much! keep up the good work.

    -eric

  75. Simon

    Hi Karl,

    What version is the jquery.js file are you using in this examples?

    Im having a problem with getting the effects to run smooth in IE 6.

    When using the latest version available at jQuery.com I get a bump at the end of the animation, but it works fine in your examples. So I tried using your jquery.js file which solved my problem, but instead something else stopped working as intended: when you click an already expanded item I dont want anything to happen. For some reason when using your version of the jquery.js the menu closes and expands if you click an expanded link.

    Here are two links to demonstrate what I mean:

    The latest version available from jQuery.com. Expanded menu does not re-expand when clicked but theres a bump at the end of the animation in IE 6:
    • my jquery.js file

    Your file. Works fine in IE 6, but an already expanded menu closes and exapands when clicked:
    • your jquery.js-file

    The relevant code is the first line in the function: $("dd").click(function()

    the line:

    $("dt:visible").not($(this).prev()).slideUp("normal")
      .css("background","url('./images/content_b.png') no-repeat scroll left top");

    My intention with the code is to say slideup all the the visible dt-elements except the clicked element.

    Am I correct assuming that .not($(this).prev()) is not handled as it should be when Im using your version of the jquery.js?

    Hope you understand my question, any help appreciated.

    Thanks for taking your time!
    Simon

  76. Rodrigo

    How do I do to make a sublink appear selected (CSS) when I click it? It should apen another page in another frame... but the menu shoud be selected after it. I already tryed the `p` parameter in the URL but didn´ work. Please I need help.. Thanks in advance.

  77. Rodrigo, inside your click handler, add a line like this:
    $(this).addClass('selected');

    Then style that class in your stylesheet.

    Hope that helps.

  78. Victor

    Hi Karl,

    Please, how can I make visible my hidden element (with an id="xyz") when it matches current page pathname - (.../page.htm#xyz)? (I want to open and scroll to it from a link on the same or another page).

    Thank you in advance for any hint.

  79. caleb

    would it be possible to change the heading on click?
    say for example, on the corner of the header i have 'expand', once i click on it, the contents display while at the same time, the word 'expand' changes to contract. im guessing the 'expand' could be just an image instead if that would make things easier?

  80. Hi Caleb,

    Yes, this is possible. Right after the line that reads var $nextDiv = $(this).next();, you can do something like this:

    if ($nextDiv.is(':visible') ) {
     $(this).text('expand');
    } else {
     $(this).text('contract');
    }
  81. caleb

    hi Karl,

    thanks for that. i've included an example of what i'm working on to give you a better understanding what i'm trying to achieve.

    please see example here and screenshot here.

    how can i have the words on the right corner to change accordingly?

    thanks for taking your time! :P

  82. Hi Caleb,
    I don't see the text in your example page (though I do see it in the screenshot). The principle will be the same as I described in comment 83, but the selector expression will just be a little different. For example, you could put a <span> inside the <h4> with the "expand" text in it, right before the other text and float it right. Then you can just change the text on clicking the <h4> the same way I showed in comment 83, except that, instead of this:

    if ($nextDiv.is(':visible') ) {
     $(this).text('expand');
    } else {
     $(this).text('contract');
    }

    you would do this:

    if ($nextDiv.is(':visible') ) {
     $('span', this).text('expand');
    } else {
     $('span', this).text('contract');
    }
  83. For a horizontal accordion you'll want to use the animate effect. Replace the code between the function brackets with something like this:

    
    $(this).next('div').animate({
       width:"100%"}, 250)
    .siblings('div').animate({
       width:"0"}, 250)
    
  84. Thanks for that, Scott! Keep in mind that this will only work with jQuery 1.2 and up.

  85. Sean

    Hi Karl,

    I'm at a total loss here. My keyboard is getting covered with the hair I've been ripping from my skull trying to get this to work. Tried to modify each of your show/hide related examples but to no avail.

    My setup is here: http://www.appelmanncreative.com/testarea/test2.html
    the css and jquery files are there on the server with it

    Basically I want the subnav to show/hide the content layers accordian style like Option 3a on this page, with the first (about us section) showing on page load.

    Can it be done?

  86. Hi Sean,
    I don't have time to write the whole script out for you, but I'm guessing that the problem you're having involves identifying the correct div to show and hide when you click on one of those links. Try pasting this into your script file. Then you can go through and replace the logic of what gets shown and hidden when by looking at the example script in this entry:

      $(document).ready(function() {
        $('#subNav > li').each(function(index) {
          $(this).click(function() {
            $('#loadContent > div:eq(' + index + ')').slideToggle();
            return false;
          });
        });
      });
  87. Sean

    Hi Karl,
    Thanks for that, but I still didn't get it to work.
    I'm not really clear on where exactly to put the logic of what gets shown and hidden when.

    thanks for taking your time!

  88. okay, Sean, take a look here:

    http://test.learningjquery.com/test2.html

    The script is in the <head>.

  89. Sean

    that's beautiful!!
    thanks again for your help!

  90. Not a problem. Glad I could help.

  91. reza

    Hi,

    How to add a fading effect during the slide motion?

    Thanx a lot for help!

  92. Hi reza,
    For that, you'll need to use the .animate() method. For example, option 3a above would look like this:

    $(document).ready(function() {
      $('div.demo-show2> div').hide();
      $('div.demo-show2> h3').click(function() {
    	$(this).next('div').animate({height: 'toggle', opacity: 'toggle'})
    	.siblings('div:visible').animate({height: 'hide', opacity: 'hide'});
      });
    });
  93. Beau

    Great Tutorial!
    I am new to Java, what would be the path in the HTML for an external .js scriprt?

  94. Just wanted to say thanks for this tutorial. Nicely done and extremely helpful.

  95. Dustin W. Gold

    Thank you very much for your hard work. I am primarily a graphic designer and have been getting into web in the last year, but have been using a programmer. I know HTML and CSS, but have been trying to learn some javascript and this is the best source that I have found.

    Thank you very much.

  96. Dustin W. Gold

    I am new at this so please be patient, but is there a way to keep the menu open when I click on links. For example, if I open "Video Solutions" and I click on a link the accordion closes. I can separate the menu using php, but it still will continue to close because it is reloading the menu. Any advise?

    http://www.e6lu2eiubr.web.aplus.net/index.php?page=about_us

        $(document).ready(function() {
            $('div.demo-show> div:gt(0)').hide(); 
    
            $('div.demo-show> h3,h4').click(function() {
    
              $(this).next('div').slideDown('fast')
    
              .siblings('div:visible').slideUp('fast');
    		  
    
            });
    
          });
  97. Hi Dustin,

    Maybe something like this:

    $(document).ready(function() {
      $('div.demo-show > div').hide(); 
      var hrefParts = location.href.split('=');
      var thisPage = hrefParts[hrefParts.length-1];
      $('div.demo-show div:has(a[href*=' + thisPage + '])').show();
      
      $('div.demo-show > h3,h4').click(function() {
        $(this).next('div').slideDown('fast')
        .siblings('div:visible').slideUp('fast');
      });
    });
  98. Dustin W. Gold

    You are a GOD! Thank you very much for your assistance. It works like a charm. I can't thank you enough. I played with it for hours and couldn't find a solution that worked.

  99. Dustin,
    LOL. I wouldn't go that far! Still, I'm very happy that it's working for you. Enjoy!

  100. Dustin W. Gold

    Do you have any tutorials on rollover/click text swaps with jquery?

20 Pings

  1. davidbisset.com » Accordion Madness

    [...] Another way to do the “accordion menu” effect using CSS [...]

  2. WebAppStory » I love jQuery - Accordion Example - Code Snippets

    [...] more on this kind of effect check here and [...]

  3. [...] More Showing, More Hiding that we are working with a simple <h3> / <div> structure: PLAIN TEXT [...]

  4. [...] Accordion Madness » Learning jQuery - Tips, Techniques, Tutorials (tags: jquery javascript menu tutorial navigation webdesign ajax css accordion) [...]

  5. 18 jQuery scripts and tutorials to improve your portfolio « Best Design Content

    [...] 14. jQuery Accordion menu [...]

  6. Gian Carlo Mingati » Blog Archive » accordion menu con jQuery

    [...] suona meglio. Ed ho deciso di condividere con voi tale idea anticipandovi che comunque ci sono già buoni tutorial e plugin sull’argomento ma nessuno, non capisco perchè, parte da un set di liste [...]

  7. [...] de longue recherches, j’ai enfin trouvé ce super tuto de Karl Swedberg (accordion-madness) en [...]

  8. 18 jQuery scripts and tutorials to improve your portfolio | Webmaster 9

    [...] 14. jQuery Accordion menu [...]

  9. Top 18: jQuery para el desarrollo y diseño web @ Ciberdix 2.0 :: Blog Creativo!!

    [...] 14. jQuery Accordion menu [...]

  10. [...] from here15.Make a Mega Drop-Down Menu with jQueryvisit the tutorial from here16.accordion menuvisit the tutorial from here17.Simple animated menu with jqueryvisit the tutorial from here18.apple style menu and improve it [...]

  11. Easy Accordion Menu with JQuery | Public Identity

    [...] http://www.learningjquery.com/2007/03/accordion-madness [...]

Sorry, but comments for this entry are now closed.